admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/contributions: Output why we default to 0 reviews on a validation error

Browse Source
This commit is contained in:
Issy Long 2023-03-15 21:31:41 +00:00
parent b6198cdd07
commit a9e31274fc
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/dev-cmd/contributions.rb
View File

@ -209,6 +209,9 @@ module Homebrew
def count_reviews(repo_full_name, person, args) def count_reviews(repo_full_name, person, args)
GitHub.count_issues("", is: "pr", repo: repo_full_name, reviewed_by: person, review: "approved", args: args) GitHub.count_issues("", is: "pr", repo: repo_full_name, reviewed_by: person, review: "approved", args: args)
rescue GitHub::API::ValidationFailedError rescue GitHub::API::ValidationFailedError
if args.verbose?
onoe "Couldn't search GitHub for PRs by #{person}. Their profile might be private. Defaulting to 0."
end
0 # Users who have made their contributions private are not searchable to determine counts. 0 # Users who have made their contributions private are not searchable to determine counts.
end end
end end