From a98991a10f295cfaf108428e191971f1cb248940 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Mon, 1 May 2017 15:45:32 +0200 Subject: [PATCH] Revert "Fix `IO#select` blocking." --- Library/Homebrew/cask/lib/hbc/system_command.rb | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Library/Homebrew/cask/lib/hbc/system_command.rb b/Library/Homebrew/cask/lib/hbc/system_command.rb index f1ec340256..c14079bc8b 100644 --- a/Library/Homebrew/cask/lib/hbc/system_command.rb +++ b/Library/Homebrew/cask/lib/hbc/system_command.rb @@ -92,25 +92,17 @@ module Hbc def each_line_from(sources) loop do - selected_sources = IO.select(sources, [], [], 10) - - break if selected_sources.nil? - - readable_sources = selected_sources[0].delete_if(&:eof?) - - readable_sources.each do |source| + readable_sources = IO.select(sources)[0] + readable_sources.delete_if(&:eof?).first(1).each do |source| type = (source == sources[0] ? :stdout : :stderr) - begin yield(type, source.readline_nonblock || "") rescue IO::WaitReadable, EOFError next end end - break if readable_sources.empty? end - sources.each(&:close_read) end