From 92a42381df63456872e7bb0971a50bf91e209ad4 Mon Sep 17 00:00:00 2001 From: Darren Kavanagh Date: Tue, 16 Mar 2021 14:50:51 -0700 Subject: [PATCH 1/2] Add additional quiet check in update-report --- Library/Homebrew/cmd/update-report.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/cmd/update-report.rb b/Library/Homebrew/cmd/update-report.rb index aeee8ffa79..8918998b25 100644 --- a/Library/Homebrew/cmd/update-report.rb +++ b/Library/Homebrew/cmd/update-report.rb @@ -91,10 +91,7 @@ module Homebrew "git", "-C", HOMEBREW_REPOSITORY, "tag", "--list", "--sort=-version:refname", "*.*" ).lines.first.chomp - if new_tag != old_tag - Settings.write "latesttag", new_tag - new_repository_version = new_tag - end + new_repository_version = new_tag unless new_tag == old_tag end Homebrew.failed = true if ENV["HOMEBREW_UPDATE_FAILED"] @@ -189,11 +186,13 @@ module Homebrew puts_stdout_or_stderr ohai_stdout_or_stderr "Homebrew was updated to version #{new_repository_version}" if new_repository_version.split(".").last == "0" + Settings.write "latesttag", new_repository_version puts_stdout_or_stderr <<~EOS More detailed release notes are available on the Homebrew Blog: #{Formatter.url("https://brew.sh/blog/#{new_repository_version}")} EOS - else + elsif !args.quiet? + Settings.write "latesttag", new_repository_version puts_stdout_or_stderr <<~EOS The changelog can be found at: #{Formatter.url("https://github.com/Homebrew/brew/releases/tag/#{new_repository_version}")} From dcfd4c2bebe3875eb994b6e3645f318d7011f863 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 24 Mar 2021 19:48:49 +0000 Subject: [PATCH 2/2] cmd/update-report: tweak syntax. --- Library/Homebrew/cmd/update-report.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/cmd/update-report.rb b/Library/Homebrew/cmd/update-report.rb index 8918998b25..02354e0305 100644 --- a/Library/Homebrew/cmd/update-report.rb +++ b/Library/Homebrew/cmd/update-report.rb @@ -91,7 +91,7 @@ module Homebrew "git", "-C", HOMEBREW_REPOSITORY, "tag", "--list", "--sort=-version:refname", "*.*" ).lines.first.chomp - new_repository_version = new_tag unless new_tag == old_tag + new_repository_version = new_tag if new_tag != old_tag end Homebrew.failed = true if ENV["HOMEBREW_UPDATE_FAILED"]