admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/resource_requires_dependencies: allow lxml build resource

Browse Source 
Specifically, a `lxml` build resource can depend on build-only `libxml2`
and `libxslt`; however, these were not detected in previous audit since
the dependency would be a hash.

Also change message if Linux-only formula.

These changes are both needed for `systemd`.

Signed-off-by: Michael Cho <michael@michaelcho.dev>
This commit is contained in:
Michael Cho 2024-04-04 18:15:12 -04:00
parent 2dc184a2ad
commit a7e5e7b8e8
No known key found for this signature in database
GPG Key ID: 55E85E28A7CD1E85
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Library/Homebrew/rubocops/resource_requires_dependencies.rb
View File

@ -23,14 +23,20 @@ module RuboCop
next unless found
uses_from_macos_nodes = find_every_method_call_by_name(body_node, :uses_from_macos)
uses_from_macos = uses_from_macos_nodes.map { |node| node.arguments.first.str_content }
depends_on_nodes = find_every_method_call_by_name(body_node, :depends_on)
depends_on = depends_on_nodes.map { |node| node.arguments.first.str_content }
uses_from_macos_or_depends_on = (uses_from_macos_nodes + depends_on_nodes).filter_map do |node|
if (dep = node.arguments.first).hash_type?
dep_types = dep.values.first
dep_types = dep_types.array_type? ? dep_types.values.map(&:value) : [dep_types.value]
dep.keys.first.str_content if dep_types.include?(:build)
else
dep.str_content
end
end
required_deps = case resource_name
when "lxml"
kind = "uses_from_macos"
kind = depends_on?(:linux) ? "depends_on" : "uses_from_macos"
["libxml2", "libxslt"]
when "pyyaml"
kind = "depends_on"
@ -38,7 +44,7 @@ module RuboCop
else
[]
end
next if required_deps.all? { |dep| uses_from_macos.include?(dep) || depends_on.include?(dep) }
next if required_deps.all? { |dep| uses_from_macos_or_depends_on.include?(dep) }
offending_node(found)
problem "Add `#{kind}` lines above for #{required_deps.map { |req| "`\"#{req}\"`" }.join(" and ")}."