test/spec_helper: Fix :needs_svn

which("svn") detects shims/scm/svn even when svn is not installed.
2018-10-24 15:40:06 -07:00 · 2018-10-24 15:40:06 -07:00 · a7ad7eee78
commit a7ad7eee78
parent a4c62d37b1
1 changed files with 4 additions and 1 deletions
--- a/Library/Homebrew/test/spec_helper.rb
+++ b/Library/Homebrew/test/spec_helper.rb
@ -98,7 +98,10 @@ RSpec.configure do |config|
  end

  config.before(:each, :needs_svn) do
-    skip "subversion not installed." unless which "svn"
+    homebrew_bin = File.dirname HOMEBREW_BREW_FILE
+    unless %W[/usr/bin/svn #{homebrew_bin}/svn].map { |x| File.executable?(x) }.any?
+      skip "subversion not installed."
+    end
  end

  config.before(:each, :needs_unzip) do