admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #8959 from Rylan12/python-symlink-rubocop

Browse Source 
audit: avoid python symlink conflict
This commit is contained in:
Rylan Polster 2020-10-20 15:47:46 -04:00 committed by GitHub
commit a6ee5b79b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/formula_cellar_checks.rb
View File

@ -265,6 +265,18 @@ module FormulaCellarChecks
EOS EOS
end end
def check_python_symlinks(name, keg_only)
return unless keg_only
return unless name.start_with? "python"
return if %w[pip3 wheel3].none? do |l|
link = HOMEBREW_PREFIX/"bin"/l
link.exist? && File.realpath(link).start_with?(HOMEBREW_CELLAR/name)
end
"Python formulae that are keg-only should not create `pip3` and `wheel3` symlinks"
end
def audit_installed def audit_installed
@new_formula ||= false @new_formula ||= false
@ -282,6 +294,7 @@ module FormulaCellarChecks
problem_if_output(check_python_packages(formula.lib, formula.deps)) problem_if_output(check_python_packages(formula.lib, formula.deps))
problem_if_output(check_shim_references(formula.prefix)) problem_if_output(check_shim_references(formula.prefix))
problem_if_output(check_plist(formula.prefix, formula.plist)) problem_if_output(check_plist(formula.prefix, formula.plist))
problem_if_output(check_python_symlinks(formula.name, formula.keg_only?))
end end
alias generic_audit_installed audit_installed alias generic_audit_installed audit_installed