admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

test-bot: better xml character filtering

Browse Source 
Ref:
 - http://www.w3.org/TR/xml/#charsets
 - http://stackoverflow.com/a/14323524

Closes Homebrew/homebrew#50092.

Signed-off-by: Xu Cheng <xucheng@me.com>
This commit is contained in:
Xu Cheng 2016-03-14 19:48:16 +08:00
parent a74e872409
commit a6b918d6c5
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/cmd/test-bot.rb
View File

@ -917,8 +917,9 @@ module Homebrew
testcase.add_attribute "time", step.time testcase.add_attribute "time", step.time
if step.has_output? if step.has_output?
# Remove invalid XML CData characters from step output. # Remove invalid XML characters
output = step.output.delete("\000\a\b\e\f\x2\x1f") # http://www.w3.org/TR/xml/#charsets
output = step.output.gsub(/[^\x09\x0A\x0D\x20-\uD7FF\uE000-\uFFFD\u10000-\u10FFFF]/, "")
if output.bytesize > BYTES_IN_1_MEGABYTE if output.bytesize > BYTES_IN_1_MEGABYTE
output = "truncated output to 1MB:\n" \ output = "truncated output to 1MB:\n" \