admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

fix: Don't invalidate the cached location if the response is a redirect

Browse Source 
A bug introduced with #19460 is that if a redirection has a file size (for example, if it is a 302 that also has HTML content), Homebrew will invalidate the cached location.
This commit is contained in:
Bob Lail 2025-04-08 11:14:56 -07:00
parent 96d32774b9
commit a6a8306c46
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/download_strategy.rb
View File

@ -486,10 +486,10 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy
# The cached location is no longer fresh if either: # The cached location is no longer fresh if either:
# - Last-Modified value is newer than the file's timestamp # - Last-Modified value is newer than the file's timestamp
# - Content-Length value is different than the file's size # - Content-Length value is different than the file's size
cached_location_valid = if cached_location_valid if cached_location_valid && !is_redirection
newer_last_modified = last_modified && last_modified > cached_location.mtime newer_last_modified = last_modified && last_modified > cached_location.mtime
different_file_size = file_size&.nonzero? && file_size != cached_location.size different_file_size = file_size&.nonzero? && file_size != cached_location.size
!(newer_last_modified || different_file_size) cached_location_valid = !(newer_last_modified || different_file_size)
end end
if cached_location_valid if cached_location_valid