admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

cmd/deps: return failing exit code on circular dependencies.

Browse Source 
This makes more sense but will also be useful in `brew test-bot`.
This commit is contained in:
Mike McQuaid 2022-08-30 12:21:02 +00:00 committed by GitHub
parent 13b060ab86
commit a5f7fc814e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/cmd/deps.rb
View File

@ -286,8 +286,14 @@ module Homebrew
end end
display_s = "#{tree_lines} #{dep_display_name(dep, args: args)}" display_s = "#{tree_lines} #{dep_display_name(dep, args: args)}"
# Detect circular dependencies and consider them a failure if present.
is_circular = dep_stack.include?(dep.name) is_circular = dep_stack.include?(dep.name)
display_s = "#{display_s} (CIRCULAR DEPENDENCY)" if is_circular if is_circular
display_s = "#{display_s} (CIRCULAR DEPENDENCY)"
Homebrew.failed = true
end
puts "#{prefix}#{display_s}" puts "#{prefix}#{display_s}"
next if !recursive || is_circular next if !recursive || is_circular