From a57764e4d64904220996aee361d527a6d6c016e4 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 16 Feb 2023 15:39:09 -0800 Subject: [PATCH] Disable FormulaCop --- Library/.rubocop.yml | 5 +++++ Library/Homebrew/rubocops/extend/formula.rb | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 843d583369..744f52c2ee 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -47,6 +47,11 @@ Cask/StanzaOrder: Description: "Ensure that cask stanzas are sorted correctly. More info at https://docs.brew.sh/Cask-Cookbook#stanza-order" Enabled: true +# This was intended to be an abstract Cop class for Homebrew formulae, but rubocop doesn't know that. +# TODO: refactor this as a module for formulae Cop classes to include instead +FormulaCop: + Enabled: false + # enable all formulae audits FormulaAudit: Enabled: true diff --git a/Library/Homebrew/rubocops/extend/formula.rb b/Library/Homebrew/rubocops/extend/formula.rb index 9da3c59555..33359bd114 100644 --- a/Library/Homebrew/rubocops/extend/formula.rb +++ b/Library/Homebrew/rubocops/extend/formula.rb @@ -21,7 +21,6 @@ module RuboCop @file_path = processed_source.buffer.name return unless file_path_allowed? return unless formula_class?(node) - return unless respond_to?(:audit_formula) class_node, parent_class_node, @body = *node @formula_name = Pathname.new(@file_path).basename(".rb").to_s