admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

style: use RuboCop 0.41.1 (#433)

Browse Source 
Tweak `Style/NumericLiteralPrefix` cop settings as we're using octal
literals a lot (both in formulae and the package manager) for file
permissions and aren't ready just yet to transition them to the more
beginner-friendly `0o` prefix (instead of the more obscure `0` prefix).
This commit is contained in:
Martin Afanasjew 2016-07-04 07:19:44 +02:00 committed by GitHub
parent f4b3dadb64
commit a49f3a8e91
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/.rubocop.yml
View File

@ -66,6 +66,10 @@ Style/EmptyLineBetweenDefs:
Style/NumericLiterals: Style/NumericLiterals:
Enabled: false Enabled: false
# zero-prefixed octal literals are just too widely used (and mostly understood)
Style/NumericLiteralPrefix:
EnforcedOctalStyle: zero_only
# consistency and readability when faced with string interpolation # consistency and readability when faced with string interpolation
Style/PercentLiteralDelimiters: Style/PercentLiteralDelimiters:
PreferredDelimiters: PreferredDelimiters:

2
Library/Homebrew/cmd/style.rb
View File

@ -47,7 +47,7 @@ module Homebrew
def check_style_impl(files, output_type, options = {}) def check_style_impl(files, output_type, options = {})
fix = options[:fix] fix = options[:fix]
Homebrew.install_gem_setup_path! "rubocop", "0.40" Homebrew.install_gem_setup_path! "rubocop", "0.41.1"
args = %W[ args = %W[
--force-exclusion --force-exclusion