admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit(github): prefer /archive/refs/tags urls over /archive

Browse Source 
Signed-off-by: Rui Chen <rui@chenrui.dev>
This commit is contained in:
Rui Chen 2023-10-20 19:10:14 -04:00
parent 35746e0a6b
commit a496f6708e
No known key found for this signature in database
GPG Key ID: 6577287BDCA70840
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/rubocops/urls.rb
View File

@ -217,6 +217,13 @@ module RuboCop
problem "Use /archive/ URLs for GitHub tarballs (url is #{url})." problem "Use /archive/ URLs for GitHub tarballs (url is #{url})."
end end
archive_ref_tags_gh_pattern = %r{https://.*github.*/archive(?!/refs/tags)/.*\.tar\.gz$}
audit_urls(urls, archive_ref_tags_gh_pattern) do |_, url|
next if url.end_with?(".git")
problem "Use /archive/refs/tags URLs for GitHub tarballs (url is #{url})."
end
# Don't use GitHub .zip files # Don't use GitHub .zip files
zip_gh_pattern = %r{https://.*github.*/(archive|releases)/.*\.zip$} zip_gh_pattern = %r{https://.*github.*/(archive|releases)/.*\.zip$}
audit_urls(urls, zip_gh_pattern) do |_, url| audit_urls(urls, zip_gh_pattern) do |_, url|

2
Library/Homebrew/utils/shared_audits.rb
View File

@ -157,7 +157,7 @@ module SharedAudits
def github_tag_from_url(url) def github_tag_from_url(url)
url = url.to_s url = url.to_s
tag = url.match(%r{^https://github\.com/[\w-]+/[\w-]+/archive/([^/]+)\.(tar\.gz|zip)$}) tag = url.match(%r{^https://github\.com/[\w-]+/[\w-]+/archive/refs/tags/([^/]+)\.(tar\.gz|zip)$})
.to_a .to_a
.second .second
tag ||= url.match(%r{^https://github\.com/[\w-]+/[\w-]+/releases/download/([^/]+)/}) tag ||= url.match(%r{^https://github\.com/[\w-]+/[\w-]+/releases/download/([^/]+)/})