From a494f9a3e0e005413238fbc87df886a829f4a632 Mon Sep 17 00:00:00 2001 From: Adam Vandenberg Date: Sun, 27 Nov 2011 08:39:44 -0800 Subject: [PATCH] audit: remove --strict --- Library/Homebrew/cmd/audit.rb | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 87d5b9d5fd..ede2ad3a32 100755 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -118,7 +118,7 @@ def audit_formula_text name, text # xcodebuild should specify SYMROOT if text =~ /xcodebuild/ and not text =~ /SYMROOT=/ problems << " * xcodebuild should be passed an explicit \"SYMROOT\"" - end if strict? + end # using ARGV.flag? for formula options is generally a bad thing if text =~ /ARGV\.flag\?/ @@ -273,16 +273,6 @@ def audit_formula_instance f return problems end -def audit_formula_caveats f - problems = [] - - if f.caveats.to_s =~ /^\s*\$\s+/ - problems << " * caveats should not use '$' prompts in multiline commands." - end if strict? - - return problems -end - module Homebrew extend self def audit errors = false @@ -291,7 +281,6 @@ module Homebrew extend self problems = [] problems += audit_formula_instance f problems += audit_formula_urls f - problems += audit_formula_caveats f perms = File.stat(f.path).mode if perms.to_s(8) != "100644"