admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/tests: Deal with TODO for a BuildPulse bug that's fixed

Browse Source 
- This does what the comment told us to do, use the bang variant of
  `system_command` to not swallow the errors.
This commit is contained in:
Issy Long 2023-03-29 00:40:46 +01:00
parent f4ee196f90
commit a480982e75
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/dev-cmd/tests.rb
View File

@ -60,13 +60,12 @@ module Homebrew
ohai "Sending test results to BuildPulse" ohai "Sending test results to BuildPulse"
# TODO: make this use `system_command!` when https://github.com/buildpulse/buildpulse-action/issues/4 is fixed system_command! Formula["buildpulse-test-reporter"].opt_bin/"buildpulse-test-reporter",
system_command Formula["buildpulse-test-reporter"].opt_bin/"buildpulse-test-reporter", args: [
args: [ "submit", "#{HOMEBREW_LIBRARY_PATH}/test/junit",
"submit", "#{HOMEBREW_LIBRARY_PATH}/test/junit", "--account-id", ENV.fetch("HOMEBREW_BUILDPULSE_ACCOUNT_ID"),
"--account-id", ENV.fetch("HOMEBREW_BUILDPULSE_ACCOUNT_ID"), "--repository-id", ENV.fetch("HOMEBREW_BUILDPULSE_REPOSITORY_ID")
"--repository-id", ENV.fetch("HOMEBREW_BUILDPULSE_REPOSITORY_ID") ]
]
end end
def changed_test_files def changed_test_files