From a4568a8697e9ff4a3d8f62e37ee929e22f10d07d Mon Sep 17 00:00:00 2001 From: Gautham Goli Date: Wed, 29 Mar 2017 02:07:53 +0530 Subject: [PATCH] Let cops run without --strict flag --- Library/Homebrew/cmd/style.rb | 6 ++++++ Library/Homebrew/dev-cmd/audit.rb | 7 ++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/cmd/style.rb b/Library/Homebrew/cmd/style.rb index 2a7f370310..d89c9b72f5 100644 --- a/Library/Homebrew/cmd/style.rb +++ b/Library/Homebrew/cmd/style.rb @@ -15,6 +15,8 @@ require "utils" require "json" +require "rubocop" +require_relative "../rubocops" module Homebrew module_function @@ -54,6 +56,10 @@ module Homebrew ] args << "--auto-correct" if fix + if options[:only] + args << "--only" << RuboCop::Cop::Cop.registry.with_department(options[:only]).names.join(" ") + end + if files.nil? args << "--config" << HOMEBREW_LIBRARY_PATH/".rubocop.yml" args += [HOMEBREW_LIBRARY_PATH] diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index be53e1d6fd..2f4b37096e 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -75,9 +75,14 @@ module Homebrew style_results = check_style_json(files, options) end + if !strict + options = { fix: ARGV.flag?("--fix"), realpath: true, only: :Homebrew } + style_results = check_style_json(files, options) + end + ff.each do |f| options = { new_formula: new_formula, strict: strict, online: online } - options[:style_offenses] = style_results.file_offenses(f.path) if strict + options[:style_offenses] = style_results.file_offenses(f.path) fa = FormulaAuditor.new(f, options) fa.audit