admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: escape dep before regexp interpolation

Browse Source
This commit is contained in:
Jack Nagel 2013-07-22 22:53:43 -05:00
parent 3afa9c2ceb
commit a3863394c0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/cmd/audit.rb
View File

@ -511,6 +511,7 @@ class FormulaAuditor
end end
def audit_conditional_dep(dep, condition, line) def audit_conditional_dep(dep, condition, line)
dep = Regexp.escape(dep)
case condition case condition
when /if build\.include\? ['"]with-#{dep}['"]$/, /if build\.with\? ['"]#{dep}['"]$/ when /if build\.include\? ['"]with-#{dep}['"]$/, /if build\.with\? ['"]#{dep}['"]$/
problem %{Replace #{line.inspect} with "depends_on #{quote_dep(dep)} => :optional"} problem %{Replace #{line.inspect} with "depends_on #{quote_dep(dep)} => :optional"}