Merge pull request #15498 from carlocab/zip-no-load-formula

unpack_strategy/zip: avoid loading formulae unnecessarily
2023-05-31 00:21:14 +08:00 · 2023-05-31 00:21:14 +08:00 · a380aed887
commit a380aed887
parent 8917acac95 0867534f3e
1 changed files with 6 additions and 4 deletions
--- a/Library/Homebrew/unpack_strategy/zip.rb
+++ b/Library/Homebrew/unpack_strategy/zip.rb
@ -23,10 +23,12 @@ module UnpackStrategy
              .returns(SystemCommand::Result)
    }
    def extract_to_dir(unpack_dir, basename:, verbose:)
-      unzip = begin
-        Formula["unzip"]
-      rescue FormulaUnavailableError
-        nil
+      unzip = if which("unzip").blank?
+        begin
+          Formula["unzip"]
+        rescue FormulaUnavailableError
+          nil
+        end
      end

      with_env(TZ: "UTC") do