admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Don't pass the read end of the pipe to exec_cmd

Browse Source
This commit is contained in:
Jack Nagel 2014-09-05 15:13:52 -05:00
parent 2efe4cc3b5
commit a211b61441
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/formula.rb
View File

@ -516,8 +516,9 @@ class Formula
begin begin
pid = fork do pid = fork do
rd.close
log.close unless out == log log.close unless out == log
exec_cmd(cmd, args, rd, out, logfn) exec_cmd(cmd, args, out, logfn)
end end
wr.close wr.close
@ -545,7 +546,7 @@ class Formula
private private
def exec_cmd(cmd, args, rd, out, logfn) def exec_cmd(cmd, args, out, logfn)
ENV['HOMEBREW_CC_LOG_PATH'] = logfn ENV['HOMEBREW_CC_LOG_PATH'] = logfn
# TODO system "xcodebuild" is deprecated, this should be removed soon. # TODO system "xcodebuild" is deprecated, this should be removed soon.
@ -560,7 +561,6 @@ class Formula
ENV.refurbish_args ENV.refurbish_args
end end
rd.close
$stdout.reopen(out) $stdout.reopen(out)
$stderr.reopen(out) $stderr.reopen(out)
args.collect!{|arg| arg.to_s} args.collect!{|arg| arg.to_s}