Merge pull request #14419 from dduugg/enable-NoExpectationExample

Enable RSpec/NoExpectationExample

Library/.rubocop_rspec.yml

@@ -15,8 +15,6 @@ RSpec/MessageSpies:
   Enabled: false
 RSpec/StubbedMock:
   Enabled: false
-RSpec/NoExpectationExample:
-  Enabled: false
 
 # TODO: try to reduce these
 RSpec/ExampleLength:

Library/Homebrew/test/formula_installer_bottle_spec.rb

@@ -67,6 +67,8 @@ describe FormulaInstaller do
     expect(f.libexec).to be_a_directory
   end
 
+  # This test wraps expect() calls in `test_basic_formula_setup`
+  # rubocop:disable RSpec/NoExpectationExample
   specify "basic bottle install" do
     allow(DevelopmentTools).to receive(:installed?).and_return(false)
     Homebrew.install_args.parse(["testball_bottle"])
@@ -74,6 +76,7 @@ describe FormulaInstaller do
       test_basic_formula_setup(f)
     end
   end
+  # rubocop:enable RSpec/NoExpectationExample
 
   specify "basic bottle install with cellar information on sha256 line" do
     allow(DevelopmentTools).to receive(:installed?).and_return(false)

Library/Homebrew/test/keg_spec.rb

@@ -268,6 +268,8 @@ describe Keg do
       expect(lib.children.length).to eq(2)
     end
 
+    # This is a legacy violation that would benefit from a clear expectation.
+    # rubocop:disable RSpec/NoExpectationExample
     it "removes broken symlinks that conflict with directories" do
       a = HOMEBREW_CELLAR/"a"/"1.0"
       (a/"lib"/"foo").mkpath
@@ -280,6 +282,7 @@ describe Keg do
 
       keg.link
     end
+    # rubocop:enable RSpec/NoExpectationExample
   end
 
   describe "#optlink" do