Merge pull request #20428 from Homebrew/fix-brew-info-for-third-party

Don't query analytics for third-party formulae/casks in `brew info`
This commit is contained in:
Rylan Polster 2025-08-11 23:20:49 +00:00 committed by GitHub
commit a0d01bc7c4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 2 deletions

View File

@ -36,6 +36,8 @@ module Cask
def self.info(cask, args:)
puts get_info(cask)
return unless cask.tap.core_cask_tap?
require "utils/analytics"
::Utils::Analytics.cask_output(cask, args:)
end

View File

@ -159,9 +159,9 @@ module Homebrew
case obj
when Formula
Utils::Analytics.formula_output(obj, args:)
Utils::Analytics.formula_output(obj, args:) if obj.core_formula?
when Cask::Cask
Utils::Analytics.cask_output(obj, args:)
Utils::Analytics.cask_output(obj, args:) if obj.tap.core_cask_tap?
when FormulaOrCaskUnavailableError
Utils::Analytics.output(filter: obj.name, args:)
else
@ -380,6 +380,8 @@ module Homebrew
ohai "Caveats", caveats_string
end
return unless formula.core_formula?
Utils::Analytics.formula_output(formula, args:)
end

View File

@ -329,6 +329,8 @@ module Utils
require "api"
return unless Homebrew::API::Formula.all_formulae.key? formula.name
json = Homebrew::API::Formula.formula_json formula.name
return if json.blank? || json["analytics"].blank?
@ -345,6 +347,8 @@ module Utils
require "api"
return unless Homebrew::API::Cask.all_casks.key? cask.token
json = Homebrew::API::Cask.cask_json cask.token
return if json.blank? || json["analytics"].blank?