admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove support for passing Formulae to pretty_*ed methods

Browse Source 
It doesn't look like these are even needed.
This commit is contained in:
Carlo Cabrera 2025-08-02 02:11:12 +08:00 committed by Carlo Cabrera
parent a76c33f7bb
commit a0a78e6c6c
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
3 changed files with 7 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/info.rb
View File

@ -371,9 +371,9 @@ module Homebrew
def decorate_dependencies(dependencies) def decorate_dependencies(dependencies)
deps_status = dependencies.map do |dep| deps_status = dependencies.map do |dep|
if dep.satisfied?([]) if dep.satisfied?([])
pretty_installed_string(dep_display_s(dep)) pretty_installed(dep_display_s(dep))
else else
pretty_uninstalled_string(dep_display_s(dep)) pretty_uninstalled(dep_display_s(dep))
end end
end end
deps_status.join(", ") deps_status.join(", ")

4
Library/Homebrew/cmd/update-report.rb
View File

@ -903,7 +903,7 @@ class ReporterHub
sig { void } sig { void }
def dump_deleted_formula_report def dump_deleted_formula_report
formulae = select_formula_or_cask(:D).sort.filter_map do |name| formulae = select_formula_or_cask(:D).sort.filter_map do |name|
pretty_uninstalled_string(name) if installed?(name) pretty_uninstalled(name) if installed?(name)
end end
output_dump_formula_or_cask_report "Deleted Installed Formulae", formulae output_dump_formula_or_cask_report "Deleted Installed Formulae", formulae
@ -915,7 +915,7 @@ class ReporterHub
casks = select_formula_or_cask(:DC).sort.filter_map do |name| casks = select_formula_or_cask(:DC).sort.filter_map do |name|
name = T.must(name.split("/").last) name = T.must(name.split("/").last)
pretty_uninstalled_string(name) if cask_installed?(name) pretty_uninstalled(name) if cask_installed?(name)
end end
output_dump_formula_or_cask_report "Deleted Installed Casks", casks output_dump_formula_or_cask_report "Deleted Installed Casks", casks

21
Library/Homebrew/extend/kernel.rb
View File

@ -234,13 +234,8 @@ module Kernel
odeprecated(method, replacement, disable: true, disable_on:, disable_for_developers:, caller:) odeprecated(method, replacement, disable: true, disable_on:, disable_for_developers:, caller:)
end end
sig { params(formula: Formula).returns(String) }
def pretty_installed(formula)
pretty_installed_string(formula.to_s)
end
sig { params(string: String).returns(String) } sig { params(string: String).returns(String) }
def pretty_installed_string(string) def pretty_installed(string)
if !$stdout.tty? if !$stdout.tty?
string string
elsif Homebrew::EnvConfig.no_emoji? elsif Homebrew::EnvConfig.no_emoji?
@ -250,13 +245,8 @@ module Kernel
end end
end end
sig { params(formula: Formula).returns(String) }
def pretty_outdated(formula)
pretty_outdated_string(formula.to_s)
end
sig { params(string: String).returns(String) } sig { params(string: String).returns(String) }
def pretty_outdated_string(string) def pretty_outdated(string)
if !$stdout.tty? if !$stdout.tty?
string string
elsif Homebrew::EnvConfig.no_emoji? elsif Homebrew::EnvConfig.no_emoji?
@ -266,13 +256,8 @@ module Kernel
end end
end end
sig { params(formula: Formula).returns(String) }
def pretty_uninstalled(formula)
pretty_uninstalled_string(formula.to_s)
end
sig { params(string: String).returns(String) } sig { params(string: String).returns(String) }
def pretty_uninstalled_string(string) def pretty_uninstalled(string)
if !$stdout.tty? if !$stdout.tty?
string string
elsif Homebrew::EnvConfig.no_emoji? elsif Homebrew::EnvConfig.no_emoji?