From a044f99d5651a6bd1a980a77c15894cb601c6ab2 Mon Sep 17 00:00:00 2001 From: Michka Popoff Date: Fri, 20 Nov 2020 22:14:56 +0100 Subject: [PATCH] on_macos/on_linux block: allow to use deprecate or disable --- Library/Homebrew/rubocops/components_order.rb | 2 ++ Library/Homebrew/test/rubocops/components_order_spec.rb | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Library/Homebrew/rubocops/components_order.rb b/Library/Homebrew/rubocops/components_order.rb index 7f6613799c..84dba9a945 100644 --- a/Library/Homebrew/rubocops/components_order.rb +++ b/Library/Homebrew/rubocops/components_order.rb @@ -150,6 +150,8 @@ module RuboCop valid_node ||= child.method_name.to_s == "patch" valid_node ||= child.method_name.to_s == "resource" + valid_node ||= child.method_name.to_s == "deprecate!" + valid_node ||= child.method_name.to_s == "disable!" @offensive_node = on_os_block @offense_source_range = on_os_block.source_range diff --git a/Library/Homebrew/test/rubocops/components_order_spec.rb b/Library/Homebrew/test/rubocops/components_order_spec.rb index 8aa6bfc867..0a925d52ca 100644 --- a/Library/Homebrew/test/rubocops/components_order_spec.rb +++ b/Library/Homebrew/test/rubocops/components_order_spec.rb @@ -324,6 +324,7 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do homepage "https://brew.sh" on_macos do + disable! because: :does_not_build depends_on "readline" end @@ -341,6 +342,7 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do homepage "https://brew.sh" on_linux do + deprecate! because: "it's deprecated" depends_on "readline" end