Merge pull request #20390 from Homebrew/show-rejected-hash

download_queue: display hash of rejected download

Library/Homebrew/download_queue.rb

@@ -82,7 +82,9 @@ module Homebrew
 
             if future.rejected?
               if exception.is_a?(ChecksumMismatchError)
+                actual = Digest::SHA256.file(downloadable.cached_download).hexdigest
                 opoo "#{downloadable.download_queue_type} reports different checksum: #{exception.expected}"
+                puts (" " * downloadable.download_queue_type.size) + " SHA-256 checksum of downloaded file: #{actual}"
                 Homebrew.failed = true if downloadable.is_a?(Resource::Patch)
                 next 2
               else

Library/Homebrew/exceptions.rb

@@ -735,7 +735,7 @@ class ChecksumMismatchError < RuntimeError
     @expected = expected
 
     super <<~EOS
-      SHA256 mismatch
+      SHA-256 mismatch
       Expected: #{Formatter.success(expected.to_s)}
         Actual: #{Formatter.error(actual.to_s)}
           File: #{path}

Library/Homebrew/retryable_download.rb

@@ -70,7 +70,7 @@ module Homebrew
 
       unless quiet
         puts "Downloaded to: #{download}" unless already_downloaded
-        puts "SHA256: #{download.sha256}"
+        puts "SHA-256: #{download.sha256}"
       end
 
       json_download = downloadable.is_a?(API::JSONDownload)

Library/Homebrew/test/exceptions_spec.rb

@@ -217,7 +217,7 @@ RSpec.describe "Exception" do
     let(:expected_checksum) { instance_double(Checksum, to_s: "deadbeef") }
     let(:actual_checksum) { instance_double(Checksum, to_s: "deadcafe") }
 
-    it(:to_s) { expect(error.to_s).to match(/SHA256 mismatch/) }
+    it(:to_s) { expect(error.to_s).to match(/SHA-256 mismatch/) }
   end
 
   describe ResourceMissingError do