From 9ef82ae1e254088e9232ba7e67afa0da9246bc6c Mon Sep 17 00:00:00 2001 From: Richie Thomas Date: Wed, 11 Oct 2017 10:51:19 -0400 Subject: [PATCH] In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods --- Library/Homebrew/cmd/readall.rb | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Library/Homebrew/cmd/readall.rb b/Library/Homebrew/cmd/readall.rb index 3591e0c09a..0fa1f7c078 100644 --- a/Library/Homebrew/cmd/readall.rb +++ b/Library/Homebrew/cmd/readall.rb @@ -13,16 +13,8 @@ module Homebrew def readall if ARGV.include?("--syntax") - ruby_files = [] - scan_files = %W[ - #{HOMEBREW_LIBRARY}/*.rb - #{HOMEBREW_LIBRARY}/Homebrew/**/*.rb - ] - Dir.glob(scan_files).each do |rb| - next if rb.include?("/vendor/") - next if rb.include?("/cask/") - ruby_files << rb - end + scan_files = "#{HOMEBREW_LIBRARY}/Homebrew/**/*.rb" + ruby_files = Dir.glob(scan_files).reject{|file| file =~ /vendor|cask/ } Homebrew.failed = true unless Readall.valid_ruby_syntax?(ruby_files) end