From d1d332aed81591f2fea69fa247c998484c5bf1c5 Mon Sep 17 00:00:00 2001 From: Lucas Astrada Date: Wed, 26 Oct 2022 21:31:52 -0300 Subject: [PATCH 1/2] Fix Oh-My-Zsh suggested configuration breaking completions on non-login shells --- docs/Shell-Completion.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Shell-Completion.md b/docs/Shell-Completion.md index 498a34a97c..7be5d71b66 100644 --- a/docs/Shell-Completion.md +++ b/docs/Shell-Completion.md @@ -46,7 +46,7 @@ then fi ``` -This must be done before `compinit` is called. Note that if you are using Oh My Zsh, it will call `compinit` for you, so this must be done before you call `oh-my-zsh.sh`. This may be done by appending the following line to your `~/.zprofile` after Homebrew's initialization, instead of modifying your `~/.zshrc` as above: +This must be done before `compinit` is called. Note that if you are using Oh My Zsh, it will call `compinit` for you when sourced. In this case, instead of the above, add the following line to your `~/.zshrc`, before you call `oh-my-zsh.sh`: ```sh FPATH="$(brew --prefix)/share/zsh/site-functions:${FPATH}" From a58dffc636d58ba3f5226eb7cfa0f5c329306538 Mon Sep 17 00:00:00 2001 From: Lucas Astrada Date: Thu, 27 Oct 2022 13:26:11 -0300 Subject: [PATCH 2/2] Reword suggestion to be more clear of command placement Co-authored-by: Mike McQuaid --- docs/Shell-Completion.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Shell-Completion.md b/docs/Shell-Completion.md index 7be5d71b66..c595b4c77f 100644 --- a/docs/Shell-Completion.md +++ b/docs/Shell-Completion.md @@ -46,7 +46,7 @@ then fi ``` -This must be done before `compinit` is called. Note that if you are using Oh My Zsh, it will call `compinit` for you when sourced. In this case, instead of the above, add the following line to your `~/.zshrc`, before you call `oh-my-zsh.sh`: +This must be done before `compinit` is called. Note that if you are using Oh My Zsh, it will call `compinit` for you when you source `oh-my-zsh.sh`. In this case, instead of the above, add the following line to your `~/.zshrc`, before you source `oh-my-zsh.sh`: ```sh FPATH="$(brew --prefix)/share/zsh/site-functions:${FPATH}"