List offending jar files when installed to lib
This commit is contained in:
		
							parent
							
								
									42d44053ef
								
							
						
					
					
						commit
						9ca233812c
					
				@ -250,15 +250,17 @@ class FormulaInstaller
 | 
				
			|||||||
  end
 | 
					  end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  def check_jars
 | 
					  def check_jars
 | 
				
			||||||
    # Check for Jars in lib
 | 
					 | 
				
			||||||
    return unless File.exist? f.lib
 | 
					    return unless File.exist? f.lib
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    unless f.lib.children.select{|g| g.to_s =~ /\.jar$/}.empty?
 | 
					    jars = f.lib.children.select{|g| g.to_s =~ /\.jar$/}
 | 
				
			||||||
 | 
					    unless jars.empty?
 | 
				
			||||||
      opoo 'JARs were installed to "lib".'
 | 
					      opoo 'JARs were installed to "lib".'
 | 
				
			||||||
      puts "Installing JARs to \"lib\" can cause conflicts between packages."
 | 
					      puts "Installing JARs to \"lib\" can cause conflicts between packages."
 | 
				
			||||||
      puts "For Java software, it is typically better for the formula to"
 | 
					      puts "For Java software, it is typically better for the formula to"
 | 
				
			||||||
      puts "install to \"libexec\" and then symlink or wrap binaries into \"bin\"."
 | 
					      puts "install to \"libexec\" and then symlink or wrap binaries into \"bin\"."
 | 
				
			||||||
      puts "See \"activemq\", \"jruby\", etc. for examples."
 | 
					      puts "See \"activemq\", \"jruby\", etc. for examples."
 | 
				
			||||||
 | 
					      puts "The offending files are:"
 | 
				
			||||||
 | 
					      puts jars
 | 
				
			||||||
      @show_summary_heading = true
 | 
					      @show_summary_heading = true
 | 
				
			||||||
    end
 | 
					    end
 | 
				
			||||||
  end
 | 
					  end
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user