From 9c9213aabd0bd12fbd611785783308715e93fb80 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Thu, 23 Feb 2023 08:45:56 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Rylan Polster Co-authored-by: Bo Anderson --- Library/Homebrew/dev-cmd/generate-cask-api.rb | 4 +++- Library/Homebrew/dev-cmd/generate-formula-api.rb | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/dev-cmd/generate-cask-api.rb b/Library/Homebrew/dev-cmd/generate-cask-api.rb index 3537854ed4..c99b41e32e 100644 --- a/Library/Homebrew/dev-cmd/generate-cask-api.rb +++ b/Library/Homebrew/dev-cmd/generate-cask-api.rb @@ -14,6 +14,8 @@ module Homebrew Homebrew::CLI::Parser.new do description <<~EOS Generates Cask API data files for formulae.brew.sh. + + The generated files are written to the current directory. EOS named_args :none @@ -40,7 +42,7 @@ module Homebrew def generate_cask_api generate_cask_api_args.parse - tap = Tap.fetch("homebrew/cask") + tap = Tap.default_cask_tap directories = ["_data/cask", "api/cask", "api/cask-source", "cask"].freeze FileUtils.rm_rf directories diff --git a/Library/Homebrew/dev-cmd/generate-formula-api.rb b/Library/Homebrew/dev-cmd/generate-formula-api.rb index 468ce3e1f0..4980898332 100644 --- a/Library/Homebrew/dev-cmd/generate-formula-api.rb +++ b/Library/Homebrew/dev-cmd/generate-formula-api.rb @@ -14,6 +14,8 @@ module Homebrew Homebrew::CLI::Parser.new do description <<~EOS Generates Formula API data files for formulae.brew.sh. + + The generated files are written to the current directory. EOS named_args :none @@ -32,7 +34,7 @@ module Homebrew --- title: #{title} layout: formula - redirect_from: /formula-linux/$TITLE + redirect_from: /formula-linux/#{title} --- {{ content }} EOS @@ -41,7 +43,7 @@ module Homebrew def generate_formula_api generate_formula_api_args.parse - tap = Tap.fetch("homebrew/core") + tap = CoreTap.instance directories = ["_data/formula", "api/formula", "formula"] FileUtils.rm_rf directories + ["_data/formula_canonical.json"]