From 9a605a1dd6449a7acc8851c7a2033fd48d9e4a33 Mon Sep 17 00:00:00 2001 From: Frank Lam Date: Tue, 28 Apr 2020 12:21:51 +0800 Subject: [PATCH] Refactor Cask#outdated_info --- Library/Homebrew/cask/cask.rb | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/cask/cask.rb b/Library/Homebrew/cask/cask.rb index 76a3824ece..957df93008 100644 --- a/Library/Homebrew/cask/cask.rb +++ b/Library/Homebrew/cask/cask.rb @@ -123,17 +123,18 @@ module Cask end def outdated_info(greedy, verbose, json) + return token unless verbose || json + + installed_versions = outdated_versions(greedy).join(", ") + if json { name: token, - installed_versions: outdated_versions(greedy).join(", "), + installed_versions: installed_versions, current_version: version, } - elsif verbose - outdated_info = token << " (#{outdated_versions(greedy).join(", ")})" - "#{outdated_info} != #{version}" else - token + "#{token} (#{installed_versions}) != #{version}" end end