test/cask: speed up tests

Library/Homebrew/test/cask/installer_spec.rb

@@ -142,7 +142,7 @@ RSpec.describe Cask::Installer, :cask do
     end
 
     it "allows already-installed Casks to be installed if force is provided" do
-      transmission = Cask::CaskLoader.load(cask_path("local-transmission"))
+      transmission = Cask::CaskLoader.load(cask_path("local-transmission-zip"))
 
       expect(transmission).not_to be_installed
 
@@ -153,6 +153,16 @@ RSpec.describe Cask::Installer, :cask do
       end.not_to raise_error
     end
 
+    it "installs a cask from a dmg file" do
+      transmission = Cask::CaskLoader.load(cask_path("local-transmission"))
+
+      expect(transmission).not_to be_installed
+
+      described_class.new(transmission).install
+
+      expect(transmission).to be_installed
+    end
+
     it "works naked-pkg-based Casks" do
       naked_pkg = Cask::CaskLoader.load(cask_path("container-pkg"))
 

Library/Homebrew/test/cask/reinstall_spec.rb

@@ -51,18 +51,18 @@ RSpec.describe Cask::Reinstall, :cask do
   end
 
   it "allows reinstalling a Cask" do
-    Cask::Installer.new(Cask::CaskLoader.load(cask_path("local-transmission"))).install
+    Cask::Installer.new(Cask::CaskLoader.load(cask_path("local-transmission-zip"))).install
 
-    expect(Cask::CaskLoader.load(cask_path("local-transmission"))).to be_installed
+    expect(Cask::CaskLoader.load(cask_path("local-transmission-zip"))).to be_installed
 
-    described_class.reinstall_casks(Cask::CaskLoader.load("local-transmission"))
-    expect(Cask::CaskLoader.load(cask_path("local-transmission"))).to be_installed
+    described_class.reinstall_casks(Cask::CaskLoader.load("local-transmission-zip"))
+    expect(Cask::CaskLoader.load(cask_path("local-transmission-zip"))).to be_installed
   end
 
   it "allows reinstalling a non installed Cask" do
-    expect(Cask::CaskLoader.load(cask_path("local-transmission"))).not_to be_installed
+    expect(Cask::CaskLoader.load(cask_path("local-transmission-zip"))).not_to be_installed
 
-    described_class.reinstall_casks(Cask::CaskLoader.load("local-transmission"))
-    expect(Cask::CaskLoader.load(cask_path("local-transmission"))).to be_installed
+    described_class.reinstall_casks(Cask::CaskLoader.load("local-transmission-zip"))
+    expect(Cask::CaskLoader.load(cask_path("local-transmission-zip"))).to be_installed
   end
 end

Library/Homebrew/test/cask/uninstall_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe Cask::Uninstall, :cask do
 
   it "can uninstall and unlink multiple Casks at once" do
     caffeine = Cask::CaskLoader.load(cask_path("local-caffeine"))
-    transmission = Cask::CaskLoader.load(cask_path("local-transmission"))
+    transmission = Cask::CaskLoader.load(cask_path("local-transmission-zip"))
 
     Cask::Installer.new(caffeine).install
     Cask::Installer.new(transmission).install

Library/Homebrew/test/cask/upgrade_spec.rb

@@ -13,7 +13,7 @@ RSpec.describe Cask::Upgrade, :cask do
   let(:auto_updates_path) { auto_updates.config.appdir.join("MyFancyApp.app") }
   let(:auto_updates) { Cask::CaskLoader.load("auto-updates") }
   let(:local_transmission_path) { local_transmission.config.appdir.join("Transmission.app") }
-  let(:local_transmission) { Cask::CaskLoader.load("local-transmission") }
+  let(:local_transmission) { Cask::CaskLoader.load("local-transmission-zip") }
   let(:local_caffeine_path) { local_caffeine.config.appdir.join("Caffeine.app") }
   let(:local_caffeine) { Cask::CaskLoader.load("local-caffeine") }
   let(:renamed_app) { Cask::CaskLoader.load("renamed-app") }
@@ -35,7 +35,7 @@ RSpec.describe Cask::Upgrade, :cask do
     let(:installed) do
       [
         "outdated/local-caffeine",
-        "outdated/local-transmission",
+        "outdated/local-transmission-zip",
         "outdated/auto-updates",
         "outdated/version-latest",
         "outdated/renamed-app",
@@ -266,7 +266,7 @@ RSpec.describe Cask::Upgrade, :cask do
     let(:installed) do
       [
         "outdated/bad-checksum",
-        "outdated/local-transmission",
+        "outdated/local-transmission-zip",
         "outdated/bad-checksum2",
       ]
     end

Library/Homebrew/test/support/fixtures/cask/Casks/local-transmission-zip.rb

@@ -0,0 +1,11 @@
+cask "local-transmission-zip" do
+  version "2.61"
+  sha256 "5e96aeb365aa8fabd51bb0d85f5f2bfe0135d392bb2f4120aa6b8171415906da"
+
+  url "file://#{TEST_FIXTURE_DIR}/cask/transmission-2.61.zip"
+  name "Transmission"
+  desc "BitTorrent client"
+  homepage "https://transmissionbt.com/"
+
+  app "Transmission.app"
+end

Library/Homebrew/test/support/fixtures/cask/Casks/outdated/local-transmission-zip.rb

@@ -0,0 +1,9 @@
+cask "local-transmission-zip" do
+  version "2.60"
+  sha256 "5e96aeb365aa8fabd51bb0d85f5f2bfe0135d392bb2f4120aa6b8171415906da"
+
+  url "file://#{TEST_FIXTURE_DIR}/cask/transmission-2.61.zip"
+  homepage "https://brew.sh/"
+
+  app "Transmission.app"
+end