From 9a25a1d5e165524f79101a580fb79488c80909fd Mon Sep 17 00:00:00 2001 From: Sean Molenaar Date: Tue, 26 Apr 2022 08:57:29 +0200 Subject: [PATCH] pr-pull: add checksum update clause --- Library/Homebrew/dev-cmd/pr-pull.rb | 2 ++ Library/Homebrew/test/dev-cmd/pr-pull_spec.rb | 17 +++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/Library/Homebrew/dev-cmd/pr-pull.rb b/Library/Homebrew/dev-cmd/pr-pull.rb index a2c7e6b4be..a595744087 100644 --- a/Library/Homebrew/dev-cmd/pr-pull.rb +++ b/Library/Homebrew/dev-cmd/pr-pull.rb @@ -144,6 +144,8 @@ module Homebrew "#{subject_name} #{new_package.version}" elsif !is_cask && old_package.revision != new_package.revision "#{subject_name}: revision #{reason}".strip + elsif is_cask && old_package.sha256 != new_package.sha256 + "#{subject_name}: checksum update #{reason}".strip else "#{subject_name}: #{reason || "rebuild"}".strip end diff --git a/Library/Homebrew/test/dev-cmd/pr-pull_spec.rb b/Library/Homebrew/test/dev-cmd/pr-pull_spec.rb index 955739b872..9366befe34 100644 --- a/Library/Homebrew/test/dev-cmd/pr-pull_spec.rb +++ b/Library/Homebrew/test/dev-cmd/pr-pull_spec.rb @@ -45,6 +45,17 @@ describe "brew pr-pull" do cask "food" do desc "Helpful description" version "1.0" + sha256 "a" + url "https://brew.sh/food-\#{version}.tgz" + end + EOS + end + let(:cask_checksum) do + <<~EOS + cask "food" do + desc "Helpful description" + version "1.0" + sha256 "b" url "https://brew.sh/food-\#{version}.tgz" end EOS @@ -53,6 +64,7 @@ describe "brew pr-pull" do <<~EOS cask "food" do version "2.0" + sha256 "a" url "https://brew.sh/food-\#{version}.tgz" end EOS @@ -61,6 +73,7 @@ describe "brew pr-pull" do <<~EOS cask "food" do version "1.0" + sha256 "a" url "https://brew.sh/food-\#{version}.tgz" end EOS @@ -164,6 +177,10 @@ describe "brew pr-pull" do expect(described_class.determine_bump_subject(cask, cask_version, cask_file)).to eq("food 2.0") end + it "correctly bumps a cask checksum" do + expect(described_class.determine_bump_subject(cask, cask_checksum, cask_file)).to eq("food: checksum update") + end + it "correctly bumps a formula revision with reason" do expect(described_class.determine_bump_subject( formula, formula_revision, formula_file, reason: "for fun"