From 99fd172ea89c1270e46e938d729aa28c9797da31 Mon Sep 17 00:00:00 2001 From: Martin Afanasjew Date: Thu, 21 Jan 2016 18:43:48 +0100 Subject: [PATCH] tests: validate developer bash commands Also change the logic a bit to iterate over the individual files per directory, as having a directory without bash commands will otherwise pass a literal `*.sh` to `bash -n`, causing it to fail. Closes Homebrew/homebrew#48323. Signed-off-by: Martin Afanasjew --- Library/Homebrew/test/test_bash.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/test/test_bash.rb b/Library/Homebrew/test/test_bash.rb index b77927e0b7..7c312f62a3 100644 --- a/Library/Homebrew/test/test_bash.rb +++ b/Library/Homebrew/test/test_bash.rb @@ -11,6 +11,10 @@ class BashTests < Homebrew::TestCase end def test_bash_cmds - assert_valid_bash_syntax "#{HOMEBREW_LIBRARY_PATH}/cmd/*.sh" + %w[cmd dev-cmd].each do |dir| + Dir["#{HOMEBREW_LIBRARY_PATH}/#{dir}/*.sh"].each do |cmd| + assert_valid_bash_syntax cmd + end + end end end