From 99c275d03b3e536ed315c67ef24ef62df15f0f40 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Thu, 24 Apr 2014 21:38:47 -0500 Subject: [PATCH] Remove slow tab completion for `brew tap` This requires hitting the network, which makes the first invocation slow. The results are inaccurate as it only pulls down the first page of results. It is also prone to false-positives. A better implementation is welcome, but in the years since I wrote this code I can't think of a single time where I found it useful. --- Library/Contributions/brew_bash_completion.sh | 10 ---------- Library/Contributions/brew_fish_completion.fish | 5 ----- Library/Contributions/cmd/brew-ls-taps.rb | 11 ----------- 3 files changed, 26 deletions(-) delete mode 100755 Library/Contributions/cmd/brew-ls-taps.rb diff --git a/Library/Contributions/brew_bash_completion.sh b/Library/Contributions/brew_bash_completion.sh index 54ce7fe098..ee2bcbed33 100644 --- a/Library/Contributions/brew_bash_completion.sh +++ b/Library/Contributions/brew_bash_completion.sh @@ -133,16 +133,6 @@ _brew_complete_tap () return ;; esac - __brew_complete_taps -} - -__brew_complete_taps () -{ - if [[ -z "$__brew_cached_taps" ]]; then - __brew_cached_taps="$(brew ls-taps)" - fi - - __brewcomp "$__brew_cached_taps" } _brew_bottle () diff --git a/Library/Contributions/brew_fish_completion.fish b/Library/Contributions/brew_fish_completion.fish index e0c6e3262f..f473be1e06 100644 --- a/Library/Contributions/brew_fish_completion.fish +++ b/Library/Contributions/brew_fish_completion.fish @@ -37,11 +37,6 @@ function __fish_complete_brew_argument return 0 end - if contains -- $cmd tap - brew ls-taps - return 0 - end - if contains -- $cmd untap ls (brew --repository)/Library/Taps 2>/dev/null | sed 's/-/\//g' return 0 diff --git a/Library/Contributions/cmd/brew-ls-taps.rb b/Library/Contributions/cmd/brew-ls-taps.rb deleted file mode 100755 index aa6909447c..0000000000 --- a/Library/Contributions/cmd/brew-ls-taps.rb +++ /dev/null @@ -1,11 +0,0 @@ -require "utils/json" - -GitHub.open("https://api.github.com/search/repositories?q=homebrew+in:name&sort=stars&per_page=100") do |json| - json["items"].each do |repo| - if repo["name"] =~ /^homebrew-(\S+)$/ - user = repo["owner"]["login"] - user = user.downcase if user == "Homebrew" - puts "#{user}/#{$1}" - end - end -end