From 14f9a2424da16c30280e6652142c56947333aec2 Mon Sep 17 00:00:00 2001
From: Issy Long <me@issyl0.co.uk>
Date: Sat, 11 Feb 2023 11:39:31 +0000
Subject: [PATCH 1/2] dev-cmd/contributions: Count commit signoffs, too

- `BrewTestBot` adds `Signed-off-by` for who approved PRs (https://github.com/Homebrew/brew/blob/1cf53b4281e7bc22a8d7fc915fc6ba4576f8ef88/Library/Homebrew/dev-cmd/pr-pull.rb#L91-L93).
- Let's count these too, at least until we can get PR approvals from the GitHub API.
---
 Library/Homebrew/dev-cmd/contributions.rb | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/Library/Homebrew/dev-cmd/contributions.rb b/Library/Homebrew/dev-cmd/contributions.rb
index 946c40b8f1..827c9a28a0 100755
--- a/Library/Homebrew/dev-cmd/contributions.rb
+++ b/Library/Homebrew/dev-cmd/contributions.rb
@@ -44,6 +44,7 @@ module Homebrew
 
     commits = 0
     coauthorships = 0
+    signoffs = 0
 
     all_repos = args.repositories.nil? || args.repositories.include?("all")
     repos = all_repos ? SUPPORTED_REPOS : args.repositories
@@ -61,11 +62,13 @@ module Homebrew
       end
 
       commits += git_log_author_cmd(T.must(repo_path), args)
-      coauthorships += git_log_coauthor_cmd(T.must(repo_path), args)
+      coauthorships += git_log_trailers_cmd(T.must(repo_path), "Co-authored-by", args)
+      signoffs += git_log_trailers_cmd(T.must(repo_path), "Signed-off-by", args)
     end
 
-    sentence = "#{args.named.first} directly authored #{commits} commits " \
-               "and co-authored #{coauthorships} commits " \
+    sentence = "#{args.named.first} directly authored #{commits} commits" \
+               ", co-authored #{coauthorships} commits" \
+               ", and signed-off #{signoffs} commits " \
                "across #{all_repos ? "all Homebrew repos" : repos.to_sentence}"
     sentence += if args.from && args.to
       " between #{args.from} and #{args.to}"
@@ -97,10 +100,10 @@ module Homebrew
     Utils.safe_popen_read(*cmd).lines.count
   end
 
-  sig { params(repo_path: Pathname, args: Homebrew::CLI::Args).returns(Integer) }
-  def git_log_coauthor_cmd(repo_path, args)
+  sig { params(repo_path: Pathname, trailer: String, args: Homebrew::CLI::Args).returns(Integer) }
+  def git_log_trailers_cmd(repo_path, trailer, args)
     cmd = ["git", "-C", repo_path, "log", "--oneline"]
-    cmd << "--format='%(trailers:key=Co-authored-by:)'"
+    cmd << "--format='%(trailers:key=#{trailer}:)'"
     cmd << "--before=#{args.to}" if args.to
     cmd << "--after=#{args.from}" if args.from
 

From abe23fb249d1e1eef70bb039f189aa2f47d6af02 Mon Sep 17 00:00:00 2001
From: Issy Long <me@issyl0.co.uk>
Date: Tue, 14 Feb 2023 10:51:11 +0000
Subject: [PATCH 2/2] dev-cmd/contributions: Add up different contribution
 types for a total
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

❯ brew contributions mikemcquaid
mikemcquaid directly authored 23766 commits, co-authored 241 commits, and signed-off 6730 commits across all Homebrew repos in all time. Total: 30737.
---
 Library/Homebrew/dev-cmd/contributions.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Library/Homebrew/dev-cmd/contributions.rb b/Library/Homebrew/dev-cmd/contributions.rb
index 827c9a28a0..b303d6574a 100755
--- a/Library/Homebrew/dev-cmd/contributions.rb
+++ b/Library/Homebrew/dev-cmd/contributions.rb
@@ -79,7 +79,7 @@ module Homebrew
     else
       " in all time"
     end
-    sentence += "."
+    sentence += ". Total: #{commits + coauthorships + signoffs}."
 
     puts sentence
   end