admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: only look for empty checksums once

Browse Source 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-02-15 22:10:03 -06:00
parent 555b16962f
commit 98dcfcfe2e
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cmd/audit.rb
View File

@ -75,18 +75,10 @@ def audit_formula_text name, text
end end
# Empty checksums # Empty checksums
if text =~ /md5\s+(''|"")/ if text =~ /(md5|sha1|sha256)\s+(''|"")/
problems << " * md5 is empty" problems << " * md5 is empty"
end end
if text =~ /sha1\s+(''|"")/
problems << " * sha1 is empty"
end
if text =~ /sha256\s+(''|"")/
problems << " * sha256 is empty"
end
# Checksum sanity check # Checksum sanity check
if text =~ /md5\s+['"](.+)['"]/ and $1 != '#{md5}' and $1 !~ /[a-f0-9]{32}/ if text =~ /md5\s+['"](.+)['"]/ and $1 != '#{md5}' and $1 !~ /[a-f0-9]{32}/
problems << " * md5 contains invalid or incorrect number of characters" problems << " * md5 contains invalid or incorrect number of characters"