audit: check for version aliases.
Current version aliases should be provided for versioned formulae so people can `brew install foo@1.2` to provide pin-like behaviour.
This commit is contained in:
parent
3f8e52e574
commit
96a8f8f172
@ -295,6 +295,27 @@ class FormulaAuditor
|
|||||||
|
|
||||||
problem "File should end with a newline" unless text.trailing_newline?
|
problem "File should end with a newline" unless text.trailing_newline?
|
||||||
|
|
||||||
|
versioned_formulae = Dir[formula.path.to_s.gsub(/\.rb$/, "@*.rb")]
|
||||||
|
needs_versioned_alias = !versioned_formulae.empty? &&
|
||||||
|
formula.tap &&
|
||||||
|
formula.aliases.grep(/.@\d/).empty?
|
||||||
|
if needs_versioned_alias
|
||||||
|
_, last_alias_version = File.basename(versioned_formulae.sort.reverse.first)
|
||||||
|
.gsub(/\.rb$/, "")
|
||||||
|
.split("@")
|
||||||
|
major, minor, = formula.version.to_s.split(".")
|
||||||
|
alias_name = if last_alias_version.split(".").length == 1
|
||||||
|
"#{formula.name}@#{major}"
|
||||||
|
else
|
||||||
|
"#{formula.name}@#{major}.#{minor}"
|
||||||
|
end
|
||||||
|
problem <<-EOS.undent
|
||||||
|
Formula has other versions so create an alias:
|
||||||
|
cd #{formula.tap.alias_dir}
|
||||||
|
ln -s #{formula.path.to_s.gsub(formula.tap.path, "..")} #{alias_name}
|
||||||
|
EOS
|
||||||
|
end
|
||||||
|
|
||||||
return unless @strict
|
return unless @strict
|
||||||
|
|
||||||
present = audit_components
|
present = audit_components
|
||||||
@ -410,7 +431,8 @@ class FormulaAuditor
|
|||||||
problem "Dependency '#{dep.name}' was renamed; use new name '#{dep_f.name}'."
|
problem "Dependency '#{dep.name}' was renamed; use new name '#{dep_f.name}'."
|
||||||
end
|
end
|
||||||
|
|
||||||
if @@aliases.include?(dep.name)
|
if @@aliases.include?(dep.name) &&
|
||||||
|
(core_formula? || !dep_f.versioned_formula?)
|
||||||
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
|
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user