admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_installer: prevent version mismatched deps

Browse Source 
Don't allow e.g. the use of `openssl` and `openssl@1.1` in the same
dependency tree to avoid runtime failures and general weirdness.
This commit is contained in:
Mike McQuaid 2016-12-13 00:37:40 +00:00
parent 666463ca2b
commit 961b5fff9d
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Library/Homebrew/formula_installer.rb
View File

@ -146,7 +146,23 @@ class FormulaInstaller
return if ignore_deps? return if ignore_deps?
recursive_deps = formula.recursive_dependencies recursive_deps = formula.recursive_dependencies
unlinked_deps = recursive_deps.map(&:to_formula).select do |dep| recursive_formulae = recursive_deps.map(&:to_formula)
version_hash = {}
version_conflicts = Set.new
recursive_formulae.each do |f|
name = f.name
unversioned_name, = name.split("@")
version_hash[unversioned_name] ||= Set.new
version_hash[unversioned_name] << name
next if version_hash[unversioned_name].length < 2
version_conflicts += version_hash[unversioned_name]
end
unless version_conflicts.empty?
raise CannotInstallFormulaError, "#{formula.full_name} contains conflicting version dependencies (#{version_conflicts.to_a.join " "}) so cannot be installed"
end
unlinked_deps = recursive_formulae.select do |dep|
dep.installed? && !dep.keg_only? && !dep.linked_keg.directory? dep.installed? && !dep.keg_only? && !dep.linked_keg.directory?
end end