From 2c89e2a762506c3a2e4924350dcef02aa70dc361 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Wr=C3=B3bel?= Date: Thu, 18 Mar 2021 20:48:25 -0400 Subject: [PATCH] brew audit --strict is not enough brew audit --strict does not catch all the issues. The CI/CD uses "brew audit --online --new-formula" and is more thorough, catching e.g. "New formulae in homebrew/core should not have a 'bottle do'" which brew audit --strict does not. --- docs/Rename-A-Formula.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Rename-A-Formula.md b/docs/Rename-A-Formula.md index e4123e7125..b117f46116 100644 --- a/docs/Rename-A-Formula.md +++ b/docs/Rename-A-Formula.md @@ -3,7 +3,7 @@ Sometimes software and formulae need to be renamed. To rename a formula you need to: -1. Rename the formula file and its class to a new formula. The new name must meet all the usual rules of formula naming. Fix any test failures that may occur due to the stricter requirements for new formulae than existing formulae (i.e. `brew audit --strict` must pass for that formula). +1. Rename the formula file and its class to a new formula. The new name must meet all the usual rules of formula naming. Fix any test failures that may occur due to the stricter requirements for new formulae than existing formulae (i.e. `brew audit --online --new-formula` must pass for that formula). 2. Create a pull request to the corresponding tap deleting the old formula file, adding the new formula file, and adding it to `formula_renames.json` with a commit message like `newack: renamed from ack`. Use the canonical name (e.g. `ack` instead of `user/repo/ack`).