From 0836cdfbeee9fe15c63cb15cb0fc06e0a7b40dec Mon Sep 17 00:00:00 2001 From: Okinea Dev <81070564+okineadev@users.noreply.github.com> Date: Tue, 14 May 2024 09:57:17 +0000 Subject: [PATCH 1/2] Added a list of extensions to pre-install in Codespaces. Improved the readability of the configuration --- .devcontainer/devcontainer.json | 29 +++++++++++++++++++++ .devcontainer/ubuntu18.04/devcontainer.json | 29 +++++++++++++++++++++ 2 files changed, 58 insertions(+) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 359aff0fd0..eb41f11cea 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,9 +1,38 @@ +// For format details, see https://aka.ms/devcontainer.json. { "name": "Homebrew/brew", "image": "ghcr.io/homebrew/brew:latest", + "workspaceFolder": "/home/linuxbrew/.linuxbrew/Homebrew", "workspaceMount": "source=${localWorkspaceFolder},target=/home/linuxbrew/.linuxbrew/Homebrew,type=bind,consistency=cached", + "onCreateCommand": ".devcontainer/on-create-command.sh", + + "customizations": { + "vscode": { + "settings": { + // Turns off the display of CPU and battery frequency (because it's useless) + // This setting is only required for GitHub Codespaces + "resmon.show.battery": false, + "resmon.show.cpufreq": false + }, + + // Installing all necessary extensions for vscode + // Taken from: .vscode/extensions.json + "extensions": [ + "kaiwood.endwise", + "lorankloeze.ruby-rubocop-revived", + "rebornix.ruby", + "sorbet.sorbet-vscode-extension", + "github.vscode-github-actions", + "timonwong.shellcheck", + "foxundermoon.shell-format", + "davidanson.vscode-markdownlint", + "editorconfig.editorconfig" + ] + } + }, + "remoteEnv": { "HOMEBREW_GITHUB_API_TOKEN": "${localEnv:GITHUB_TOKEN}" } diff --git a/.devcontainer/ubuntu18.04/devcontainer.json b/.devcontainer/ubuntu18.04/devcontainer.json index 9e2f7d5276..47ec4c48a3 100644 --- a/.devcontainer/ubuntu18.04/devcontainer.json +++ b/.devcontainer/ubuntu18.04/devcontainer.json @@ -1,9 +1,38 @@ +// For format details, see https://aka.ms/devcontainer.json. { "name": "Homebrew/brew-ubuntu18.04", "image": "ghcr.io/homebrew/ubuntu18.04:latest", + "workspaceFolder": "/home/linuxbrew/.linuxbrew/Homebrew", "workspaceMount": "source=${localWorkspaceFolder},target=/home/linuxbrew/.linuxbrew/Homebrew,type=bind,consistency=cached", + "onCreateCommand": ".devcontainer/on-create-command.sh", + + "customizations": { + "vscode": { + "settings": { + // Turns off the display of CPU and battery frequency (because it's useless) + // This setting is only required for GitHub Codespaces + "resmon.show.battery": false, + "resmon.show.cpufreq": false + }, + + // Installing all necessary extensions for vscode + // Taken from: .vscode/extensions.json + "extensions": [ + "kaiwood.endwise", + "lorankloeze.ruby-rubocop-revived", + "rebornix.ruby", + "sorbet.sorbet-vscode-extension", + "github.vscode-github-actions", + "timonwong.shellcheck", + "foxundermoon.shell-format", + "davidanson.vscode-markdownlint", + "editorconfig.editorconfig" + ] + } + }, + "remoteEnv": { "HOMEBREW_GITHUB_API_TOKEN": "${localEnv:GITHUB_TOKEN}" } From 39aaf333403e8b4d636ff6fc08650e9f67f9ff77 Mon Sep 17 00:00:00 2001 From: Okinea Dev <81070564+okineadev@users.noreply.github.com> Date: Tue, 14 May 2024 11:29:28 +0000 Subject: [PATCH 2/2] Removed `"settings"` section --- .devcontainer/devcontainer.json | 7 ------- .devcontainer/ubuntu18.04/devcontainer.json | 7 ------- 2 files changed, 14 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index eb41f11cea..0c51923f88 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -10,13 +10,6 @@ "customizations": { "vscode": { - "settings": { - // Turns off the display of CPU and battery frequency (because it's useless) - // This setting is only required for GitHub Codespaces - "resmon.show.battery": false, - "resmon.show.cpufreq": false - }, - // Installing all necessary extensions for vscode // Taken from: .vscode/extensions.json "extensions": [ diff --git a/.devcontainer/ubuntu18.04/devcontainer.json b/.devcontainer/ubuntu18.04/devcontainer.json index 47ec4c48a3..e2f96d8f5e 100644 --- a/.devcontainer/ubuntu18.04/devcontainer.json +++ b/.devcontainer/ubuntu18.04/devcontainer.json @@ -10,13 +10,6 @@ "customizations": { "vscode": { - "settings": { - // Turns off the display of CPU and battery frequency (because it's useless) - // This setting is only required for GitHub Codespaces - "resmon.show.battery": false, - "resmon.show.cpufreq": false - }, - // Installing all necessary extensions for vscode // Taken from: .vscode/extensions.json "extensions": [