From 95c06f5ad5fc15cd394fa936c78afc9923a6c09b Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Fri, 14 Jul 2023 12:57:23 +0800 Subject: [PATCH] rubocops/lines: simplify PyoxidizerCheck --- Library/Homebrew/rubocops/lines.rb | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index be988c419a..47dfb2d3d4 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -226,24 +226,11 @@ module RuboCop class PyoxidizerCheck < FormulaCop def audit_formula(_node, _class_node, _parent_class_node, body_node) return if body_node.nil? - # Disallow use of PyOxidizer as a dependency in core return if formula_tap != "homebrew-core" + return unless depends_on?("pyoxidizer") - find_method_with_args(body_node, :depends_on, "pyoxidizer") do - problem "Formulae in homebrew/core should not use '#{@offensive_node.source}'." - end - - [ - :build, - [:build], - [:build, :test], - [:test, :build], - ].each do |type| - find_method_with_args(body_node, :depends_on, "pyoxidizer" => type) do - problem "Formulae in homebrew/core should not use '#{@offensive_node.source}'." - end - end + problem "Formulae in homebrew/core should not use '#{@offensive_node.source}'." end end