From 94c083dc2b94fc77aa6cf70677b94c1b06ccb007 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Sat, 5 Jul 2014 19:13:43 -0500 Subject: [PATCH] brew-pull: combine conditionals --- Library/Contributions/cmd/brew-pull.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Contributions/cmd/brew-pull.rb b/Library/Contributions/cmd/brew-pull.rb index c7d9d02cfa..fd6c3fa7c0 100755 --- a/Library/Contributions/cmd/brew-pull.rb +++ b/Library/Contributions/cmd/brew-pull.rb @@ -20,6 +20,7 @@ end ARGV.named.each do |arg| if arg.to_i > 0 url = 'https://github.com/Homebrew/homebrew/pull/' + arg + issue = arg else url_match = arg.match HOMEBREW_PULL_OR_COMMIT_URL_REGEX unless url_match @@ -28,6 +29,7 @@ ARGV.named.each do |arg| end url = url_match[0] + issue = url_match[4] end if tap_name = tap(url) @@ -39,8 +41,6 @@ ARGV.named.each do |arg| Dir.chdir HOMEBREW_REPOSITORY end - issue = arg.to_i > 0 ? arg.to_i : url_match[4] - if ARGV.include? '--bottle' raise 'No pull request detected!' unless issue url = "https://github.com/BrewTestBot/homebrew/compare/homebrew:master...pr-#{issue}"