From 94409712feb56b136e82645da6c9f422fa2c2691 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Mon, 2 Jul 2018 10:25:04 +0100 Subject: [PATCH] install: don't exit on Homebrew.failed? This will be set if e.g. pinned packages aren't being upgraded. Fixes #4388. --- Library/Homebrew/install.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/install.rb b/Library/Homebrew/install.rb index f86c096a9d..fd6f7f6a95 100644 --- a/Library/Homebrew/install.rb +++ b/Library/Homebrew/install.rb @@ -27,12 +27,14 @@ module Homebrew def check_development_tools checks = Diagnostic::Checks.new + failed = false checks.fatal_development_tools_checks.each do |check| out = checks.send(check) next if out.nil? + failed ||= true ofail out end - exit 1 if Homebrew.failed? + exit 1 if failed end def check_cellar