admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

version: fix bad regexps in version parsers

Browse Source 
The character class `[.-v]` is interpreted as all the characters between
`.` and `v`, which is clearly not what is intended here.

Here's an example of what this fixes. Before:

    ❯ brew ruby -e 'puts Version.detect("https://github.com/llvm/llvm-project/releases/download/llvmorg-16.0.0-rc1/llvm-project-16.0.0rc1.src.tar.xz")'
    6.0.0rc1

After:

    ❯ brew ruby -e 'puts Version.detect("https://github.com/llvm/llvm-project/releases/download/llvmorg-16.0.0-rc1/llvm-project-16.0.0rc1.src.tar.xz")'
    16.0.0rc1

The problem here is that `1` is a match for `/[.-v]/`.

    ❯ brew ruby -e 'puts /[.-v]/.match("1")'
    1
This commit is contained in:
Carlo Cabrera 2023-02-01 10:48:45 +08:00
parent 7a5f6143d3
commit 93fd448c6c
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/version.rb
View File

@ -467,7 +467,7 @@ class Version
# e.g. https://github.com/dlang/dmd/archive/v2.074.0-beta1.tar.gz
# e.g. https://github.com/dlang/dmd/archive/v2.074.0-rc1.tar.gz
# e.g. https://github.com/premake/premake-core/releases/download/v5.0.0-alpha10/premake-5.0.0-alpha10-src.zip
StemParser.new(/[.-vV]?(#{NUMERIC_WITH_DOTS}#{PRERELEASE_SUFFIX})/),
StemParser.new(/[-.vV]?(#{NUMERIC_WITH_DOTS}#{PRERELEASE_SUFFIX})/),
# e.g. foobar4.5.1
StemParser.new(/(#{NUMERIC_WITH_OPTIONAL_DOTS})$/),
@ -505,7 +505,7 @@ class Version
StemParser.new(/\.v(\d+[a-z]?)/),
# e.g. https://secure.php.net/get/php-7.1.10.tar.bz2/from/this/mirror
UrlParser.new(/[.-vV]?(#{NUMERIC_WITH_DOTS}#{PRERELEASE_SUFFIX}?)/),
UrlParser.new(/[-.vV]?(#{NUMERIC_WITH_DOTS}#{PRERELEASE_SUFFIX}?)/),
].freeze
private_constant :VERSION_PARSERS