From 12070b4c0fd0f41151c10ad2322168e7aa30fa9e Mon Sep 17 00:00:00 2001 From: Steve Peters Date: Tue, 25 Aug 2020 18:34:18 -0700 Subject: [PATCH] upgrade: fix undefined method Add the `Homebrew.` module prefix to fix an undefined method. Also, use `uniq` to deduplicate the list of broken dependents. --- Library/Homebrew/upgrade.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/upgrade.rb b/Library/Homebrew/upgrade.rb index e1dab76e7a..87ac4d4c33 100644 --- a/Library/Homebrew/upgrade.rb +++ b/Library/Homebrew/upgrade.rb @@ -170,6 +170,7 @@ module Homebrew oh1 "Checking for dependents of upgraded formulae..." unless args.dry_run? broken_dependents = CacheStoreDatabase.use(:linkage) do |db| installed_formulae.flat_map(&:runtime_installed_formula_dependents) + .uniq .select do |f| keg = f.opt_or_installed_prefix_keg next unless keg @@ -221,7 +222,7 @@ module Homebrew return if args.dry_run? reinstallable_broken_dependents.each do |f| - reinstall_formula(f, build_from_source: true, args: args) + Homebrew.reinstall_formula(f, build_from_source: true, args: args) rescue FormulaInstallationAlreadyAttemptedError # We already attempted to reinstall f as part of the dependency tree of # another formula. In that case, don't generate an error, just move on.