Merge pull request #1125 from reitermarkus/rubocop-macos

RuboCop: MacOS

Library/.rubocop_todo.yml

@@ -96,11 +96,6 @@ Style/ClassVars:
     - 'Homebrew/test/testing_env.rb'
     - 'Homebrew/utils.rb'
 
-# Offense count: 1
-Style/ConstantName:
-  Exclude:
-    - 'Homebrew/os/mac.rb'
-
 # Offense count: 13
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
@@ -129,7 +124,6 @@ Style/IndentArray:
 Style/ModuleFunction:
   Exclude:
     - 'Homebrew/global.rb'
-    - 'Homebrew/os/mac.rb'
     - 'Homebrew/os/mac/xcode.rb'
     - 'Homebrew/os/mac/xquartz.rb'
 

Library/Homebrew/cask/lib/hbc/macos.rb

@@ -4,6 +4,8 @@ require "os/mac/version"
 
 module OS
   module Mac
+    module_function
+
     SYSTEM_DIRS = [
                     "/",
                     "/Applications",

Library/Homebrew/compat/macos.rb

@@ -2,145 +2,145 @@ require "development_tools"
 
 module OS
   module Mac
-    class << self
+    module_function
-      def xcode_folder
-        odeprecated "MacOS.xcode_folder", "MacOS::Xcode.folder"
-        Xcode.folder
-      end
 
-      def xcode_prefix
+    def xcode_folder
-        odeprecated "MacOS.xcode_prefix", "MacOS::Xcode.prefix"
+      odeprecated "MacOS.xcode_folder", "MacOS::Xcode.folder"
-        Xcode.prefix
+      Xcode.folder
-      end
+    end
 
-      def xcode_installed?
+    def xcode_prefix
-        odeprecated "MacOS.xcode_installed?", "MacOS::Xcode.installed?"
+      odeprecated "MacOS.xcode_prefix", "MacOS::Xcode.prefix"
-        Xcode.installed?
+      Xcode.prefix
-      end
+    end
 
-      def xcode_version
+    def xcode_installed?
-        odeprecated "MacOS.xcode_version", "MacOS::Xcode.version"
+      odeprecated "MacOS.xcode_installed?", "MacOS::Xcode.installed?"
-        Xcode.version
+      Xcode.installed?
-      end
+    end
 
-      def clt_installed?
+    def xcode_version
-        odeprecated "MacOS.clt_installed?", "MacOS::CLT.installed?"
+      odeprecated "MacOS.xcode_version", "MacOS::Xcode.version"
-        CLT.installed?
+      Xcode.version
-      end
+    end
 
-      def clt_version?
+    def clt_installed?
-        odeprecated "MacOS.clt_version?", "MacOS::CLT.version"
+      odeprecated "MacOS.clt_installed?", "MacOS::CLT.installed?"
-        CLT.version
+      CLT.installed?
-      end
+    end
 
-      def x11_installed?
+    def clt_version?
-        odeprecated "MacOS.x11_installed?", "MacOS::X11.installed?"
+      odeprecated "MacOS.clt_version?", "MacOS::CLT.version"
-        X11.installed?
+      CLT.version
-      end
+    end
 
-      def x11_prefix
+    def x11_installed?
-        odeprecated "MacOS.x11_prefix", "MacOS::X11.prefix"
+      odeprecated "MacOS.x11_installed?", "MacOS::X11.installed?"
-        X11.prefix
+      X11.installed?
-      end
+    end
 
-      def leopard?
+    def x11_prefix
-        odeprecated "MacOS.leopard?", "'MacOS.version == :leopard'"
+      odeprecated "MacOS.x11_prefix", "MacOS::X11.prefix"
-        version == :leopard
+      X11.prefix
-      end
+    end
 
-      def snow_leopard?
+    def leopard?
-        odeprecated "MacOS.snow_leopard?", "'MacOS.version >= :snow_leopard'"
+      odeprecated "MacOS.leopard?", "'MacOS.version == :leopard'"
-        version >= :snow_leopard
+      version == :leopard
-      end
+    end
 
-      def snow_leopard_or_newer?
+    def snow_leopard?
-        odeprecated "MacOS.snow_leopard_or_newer?", "'MacOS.version >= :snow_leopard'"
+      odeprecated "MacOS.snow_leopard?", "'MacOS.version >= :snow_leopard'"
-        version >= :snow_leopard
+      version >= :snow_leopard
-      end
+    end
 
-      def lion?
+    def snow_leopard_or_newer?
-        odeprecated "MacOS.lion?", "'MacOS.version >= :lion'"
+      odeprecated "MacOS.snow_leopard_or_newer?", "'MacOS.version >= :snow_leopard'"
-        version >= :lion
+      version >= :snow_leopard
-      end
+    end
 
-      def lion_or_newer?
+    def lion?
-        odeprecated "MacOS.lion_or_newer?", "'MacOS.version >= :lion'"
+      odeprecated "MacOS.lion?", "'MacOS.version >= :lion'"
-        version >= :lion
+      version >= :lion
-      end
+    end
 
-      def mountain_lion?
+    def lion_or_newer?
-        odeprecated "MacOS.mountain_lion?", "'MacOS.version >= :mountain_lion'"
+      odeprecated "MacOS.lion_or_newer?", "'MacOS.version >= :lion'"
-        version >= :mountain_lion
+      version >= :lion
-      end
+    end
 
-      def mountain_lion_or_newer?
+    def mountain_lion?
-        odeprecated "MacOS.mountain_lion_or_newer?", "'MacOS.version >= :mountain_lion'"
+      odeprecated "MacOS.mountain_lion?", "'MacOS.version >= :mountain_lion'"
-        version >= :mountain_lion
+      version >= :mountain_lion
-      end
+    end
 
-      def macports_or_fink_installed?
+    def mountain_lion_or_newer?
-        odeprecated "MacOS.macports_or_fink_installed?", "!MacOS.macports_or_fink.empty?"
+      odeprecated "MacOS.mountain_lion_or_newer?", "'MacOS.version >= :mountain_lion'"
-        !macports_or_fink.empty?
+      version >= :mountain_lion
-      end
+    end
 
-      def locate(tool)
+    def macports_or_fink_installed?
-        odeprecated "MacOS.locate", "DevelopmentTools.locate"
+      odeprecated "MacOS.macports_or_fink_installed?", "!MacOS.macports_or_fink.empty?"
-        DevelopmentTools.locate(tool)
+      !macports_or_fink.empty?
-      end
+    end
 
-      def default_cc
+    def locate(tool)
-        odeprecated "MacOS.default_cc", "DevelopmentTools.default_cc"
+      odeprecated "MacOS.locate", "DevelopmentTools.locate"
-        DevelopmentTools.default_cc
+      DevelopmentTools.locate(tool)
-      end
+    end
 
-      def default_compiler
+    def default_cc
-        odeprecated "MacOS.default_compiler", "DevelopmentTools.default_compiler"
+      odeprecated "MacOS.default_cc", "DevelopmentTools.default_cc"
-        DevelopmentTools.default_compiler
+      DevelopmentTools.default_cc
-      end
+    end
 
-      def gcc_40_build_version
+    def default_compiler
-        odeprecated "MacOS.gcc_40_build_version", "DevelopmentTools.gcc_40_build_version"
+      odeprecated "MacOS.default_compiler", "DevelopmentTools.default_compiler"
-        DevelopmentTools.gcc_40_build_version
+      DevelopmentTools.default_compiler
-      end
+    end
 
-      def gcc_4_0_build_version
+    def gcc_40_build_version
-        odeprecated "MacOS.gcc_4_0_build_version", "DevelopmentTools.gcc_40_build_version"
+      odeprecated "MacOS.gcc_40_build_version", "DevelopmentTools.gcc_40_build_version"
-        DevelopmentTools.gcc_40_build_version
+      DevelopmentTools.gcc_40_build_version
-      end
+    end
 
-      def gcc_42_build_version
+    def gcc_4_0_build_version
-        odeprecated "MacOS.gcc_42_build_version", "DevelopmentTools.gcc_42_build_version"
+      odeprecated "MacOS.gcc_4_0_build_version", "DevelopmentTools.gcc_40_build_version"
-        DevelopmentTools.gcc_42_build_version
+      DevelopmentTools.gcc_40_build_version
-      end
+    end
 
-      def gcc_build_version
+    def gcc_42_build_version
-        odeprecated "MacOS.gcc_build_version", "DevelopmentTools.gcc_42_build_version"
+      odeprecated "MacOS.gcc_42_build_version", "DevelopmentTools.gcc_42_build_version"
-        DevelopmentTools.gcc_42_build_version
+      DevelopmentTools.gcc_42_build_version
-      end
+    end
 
-      def llvm_build_version
+    def gcc_build_version
-        odeprecated "MacOS.llvm_build_version"
+      odeprecated "MacOS.gcc_build_version", "DevelopmentTools.gcc_42_build_version"
-      end
+      DevelopmentTools.gcc_42_build_version
+    end
 
-      def clang_version
+    def llvm_build_version
-        odeprecated "MacOS.clang_version", "DevelopmentTools.clang_version"
+      odeprecated "MacOS.llvm_build_version"
-        DevelopmentTools.clang_version
+    end
-      end
 
-      def clang_build_version
+    def clang_version
-        odeprecated "MacOS.clang_build_version", "DevelopmentTools.clang_build_version"
+      odeprecated "MacOS.clang_version", "DevelopmentTools.clang_version"
-        DevelopmentTools.clang_build_version
+      DevelopmentTools.clang_version
-      end
+    end
 
-      def has_apple_developer_tools?
+    def clang_build_version
-        odeprecated "MacOS.has_apple_developer_tools?", "DevelopmentTools.installed?"
+      odeprecated "MacOS.clang_build_version", "DevelopmentTools.clang_build_version"
-        DevelopmentTools.installed?
+      DevelopmentTools.clang_build_version
-      end
+    end
 
-      def release
+    def has_apple_developer_tools?
-        odeprecated "MacOS.release", "MacOS.version"
+      odeprecated "MacOS.has_apple_developer_tools?", "DevelopmentTools.installed?"
-        version
+      DevelopmentTools.installed?
-      end
+    end
+
+    def release
+      odeprecated "MacOS.release", "MacOS.version"
+      version
     end
   end
 end

Library/Homebrew/compat/xcode.rb

@@ -1,11 +1,11 @@
 module OS
   module Mac
     module Xcode
-      class << self
+      module_function
-        def provides_autotools?
+
-          odeprecated "OS::Mac::Xcode.provides_autotools?"
+      def provides_autotools?
-          version < "4.3"
+        odeprecated "OS::Mac::Xcode.provides_autotools?"
-        end
+        version < "4.3"
       end
     end
   end

Library/Homebrew/os/mac.rb

@@ -9,9 +9,9 @@ require "os/mac/keg"
 
 module OS
   module Mac
-    extend self
+    module_function
 
-    ::MacOS = self # compatibility
+    ::MacOS = self # rubocop:disable Style/ConstantName
 
     raise "Loaded OS::Mac on generic OS!" if ENV["HOMEBREW_TEST_GENERIC_OS"]
 

Library/Homebrew/os/mac/xcode.rb

@@ -1,7 +1,7 @@
 module OS
   module Mac
     module Xcode
-      extend self
+      module_function
 
       V4_BUNDLE_ID = "com.apple.dt.Xcode".freeze
       V3_BUNDLE_ID = "com.apple.Xcode".freeze

Library/Homebrew/os/mac/xquartz.rb

@@ -3,7 +3,7 @@ module OS
     X11 = XQuartz = Module.new
 
     module XQuartz
-      extend self
+      module_function
 
       FORGE_BUNDLE_ID = "org.macosforge.xquartz.X11".freeze
       APPLE_BUNDLE_ID = "org.x.X11".freeze