admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection

Browse Source 
This is implements the first audit discussed in #11608.
This commit is contained in:
Carlo Cabrera 2021-07-01 18:38:54 +01:00
parent 89aeaffd9f
commit 92d224f0fc
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/rubocops/lines.rb
View File

@ -540,6 +540,13 @@ module RuboCop
problem "macOS has been 64-bit only since 10.6 so ENV.universal_binary is deprecated." problem "macOS has been 64-bit only since 10.6 so ENV.universal_binary is deprecated."
end end
find_instance_method_call(body_node, "ENV", :runtime_cpu_detection) do
next if tap_style_exception? :runtime_cpu_detection_allowlist
problem "Formulae should be verified as having support for runtime hardware detection before " \
"using ENV.runtime_cpu_detection."
end
find_every_method_call_by_name(body_node, :depends_on).each do |method| find_every_method_call_by_name(body_node, :depends_on).each do |method|
next unless method_called?(method, :new) next unless method_called?(method, :new)