admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

cmd/audit: fix type error in cask livecheck url audit

Browse Source 
This got updated recently in 42a42c96acc5193dbb6e321ff2aaecceb00e48a4
to split out the livecheck audits and as a result of that the type
signature for the #validate_url_for_https_availablity method got updated.

This did not account for the possibility that the livecheck url was nil.
I've added a nil check here since it makes no sense to try and validate
a nil url and we have nil checks for the other two http availability
audits already. Plus, the livecheck blocks are audited thoroughly already
for syntax.
This commit is contained in:
apainintheneck 2024-01-07 15:45:24 -08:00
parent 42a42c96ac
commit 926c5b739a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/cask/audit.rb
View File

@ -806,10 +806,11 @@ module Cask
def audit_livecheck_https_availability def audit_livecheck_https_availability
return unless online? return unless online?
return unless cask.livecheckable? return unless cask.livecheckable?
return if cask.livecheck.url.is_a?(Symbol) return unless (url = cask.livecheck.url)
return if url.is_a?(Symbol)
validate_url_for_https_availability( validate_url_for_https_availability(
cask.livecheck.url, "livecheck URL", url, "livecheck URL",
check_content: true check_content: true
) )
end end