From 921485c6722e71310036c8562487bedca2d5e45c Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Sat, 19 Dec 2020 20:36:41 +0100 Subject: [PATCH] =?UTF-8?q?Don't=20print=20backtrace=20for=20=E2=80=9CUnab?= =?UTF-8?q?le=20to=20get=20versions=E2=80=9D=20error.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Library/Homebrew/livecheck/error.rb | 12 ++++++++++++ Library/Homebrew/livecheck/livecheck.rb | 5 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) create mode 100644 Library/Homebrew/livecheck/error.rb diff --git a/Library/Homebrew/livecheck/error.rb b/Library/Homebrew/livecheck/error.rb new file mode 100644 index 0000000000..a10875551b --- /dev/null +++ b/Library/Homebrew/livecheck/error.rb @@ -0,0 +1,12 @@ +# typed: true +# frozen_string_literal: true + +module Homebrew + module Livecheck + # Error during a livecheck run. + # + # @api private + class Error < RuntimeError + end + end +end diff --git a/Library/Homebrew/livecheck/livecheck.rb b/Library/Homebrew/livecheck/livecheck.rb index 91588946a0..ece9c04656 100644 --- a/Library/Homebrew/livecheck/livecheck.rb +++ b/Library/Homebrew/livecheck/livecheck.rb @@ -1,6 +1,7 @@ # typed: false # frozen_string_literal: true +require "livecheck/error" require "livecheck/strategy" require "ruby-progressbar" require "uri" @@ -145,7 +146,7 @@ module Homebrew if latest.blank? no_versions_msg = "Unable to get versions" - raise TypeError, no_versions_msg unless json + raise Livecheck::Error, no_versions_msg unless json next version_info if version_info.is_a?(Hash) && version_info[:status] && version_info[:messages] @@ -201,7 +202,7 @@ module Homebrew status_hash(formula_or_cask, "error", [e.to_s], full_name: full_name, verbose: verbose) elsif !quiet onoe "#{Tty.blue}#{formula_or_cask_name(formula_or_cask, full_name: full_name)}#{Tty.reset}: #{e}" - $stderr.puts e.backtrace if debug + $stderr.puts e.backtrace if debug && !e.is_a?(Livecheck::Error) nil end end