From 91ce799fe2c7432795a0f74e5ce84b6fd272d1f4 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Sun, 6 Dec 2020 23:47:12 +0100 Subject: [PATCH] Ignore empty version strings. --- Library/Homebrew/dev-cmd/bump-unversioned-casks.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/dev-cmd/bump-unversioned-casks.rb b/Library/Homebrew/dev-cmd/bump-unversioned-casks.rb index eea043e0aa..a65d134fd4 100644 --- a/Library/Homebrew/dev-cmd/bump-unversioned-casks.rb +++ b/Library/Homebrew/dev-cmd/bump-unversioned-casks.rb @@ -233,8 +233,8 @@ module Homebrew def self.version_from_info_plist(info_plist_path) plist = system_command!("plutil", args: ["-convert", "xml1", "-o", "-", info_plist_path]).plist - short_version = plist["CFBundleShortVersionString"] - version = plist["CFBundleVersion"] + short_version = plist["CFBundleShortVersionString"].presence + version = plist["CFBundleVersion"].presence return decide_between_versions(short_version, version) if short_version && version end @@ -243,8 +243,8 @@ module Homebrew def self.version_from_package_info(package_info_path) contents = package_info_path.read - short_version = contents[/CFBundleShortVersionString="([^"]*)"/, 1] - version = contents[/CFBundleVersion="([^"]*)"/, 1] + short_version = contents[/CFBundleShortVersionString="([^"]*)"/, 1].presence + version = contents[/CFBundleVersion="([^"]*)"/, 1].presence return decide_between_versions(short_version, version) if short_version && version end