From 9134718f9caca3b029e8cc538497fd8a61b77551 Mon Sep 17 00:00:00 2001 From: "Tim D. Smith" Date: Wed, 1 Oct 2014 18:40:04 -0700 Subject: [PATCH] =?UTF-8?q?Audit=20formul=C3=A6=20for=20easy-install.pth?= =?UTF-8?q?=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes Homebrew/homebrew#32860. --- Library/Homebrew/cmd/audit.rb | 1 + Library/Homebrew/formula_cellar_checks.rb | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index cbfb67dced..e7e3868a4b 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -568,6 +568,7 @@ class FormulaAuditor audit_check_output(check_non_executables(f.sbin)) audit_check_output(check_generic_executables(f.sbin)) audit_check_output(check_shadowed_headers) + audit_check_output(check_easy_install_pth(f.lib)) end def audit diff --git a/Library/Homebrew/formula_cellar_checks.rb b/Library/Homebrew/formula_cellar_checks.rb index f639c20461..372fcca87f 100644 --- a/Library/Homebrew/formula_cellar_checks.rb +++ b/Library/Homebrew/formula_cellar_checks.rb @@ -120,6 +120,19 @@ module FormulaCellarChecks "The offending files are: \n #{files * "\n "}"] end + def check_easy_install_pth lib + pth_found = Dir["#{lib}/python{2.7,3.4}/site-packages/easy-install.pth"].map { |f| File.dirname(f) } + return if pth_found.empty? + + ["easy-install.pth files were found in #{pth_found.join(", ")}.", + <<-EOS.undent + These .pth files are likely to cause link conflicts. Please + invoke setup.py with options --single-version-externally-managed + --record=install.txt. + EOS + ] + end + private def relative_glob(dir, pattern)