admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #2283 from reitermarkus/cask-cli-argumenterror

Browse Source 
Use `ArgumentError` instead of `CaskError` in `CLI`.
This commit is contained in:
Markus Reiter 2017-03-08 03:35:37 +01:00 committed by GitHub
commit 9105acab6b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cask/lib/hbc/cli.rb
View File

@ -229,9 +229,9 @@ module Hbc
remaining << head remaining << head
retry retry
rescue OptionParser::MissingArgument rescue OptionParser::MissingArgument
raise CaskError, "The option '#{head}' requires an argument" raise ArgumentError, "The option '#{head}' requires an argument."
rescue OptionParser::AmbiguousOption rescue OptionParser::AmbiguousOption
raise CaskError, "There is more than one possible option that starts with '#{head}'" raise ArgumentError, "There is more than one possible option that starts with '#{head}'."
end end
end end

4
Library/Homebrew/test/cask/cli/options_spec.rb
View File

@ -108,7 +108,7 @@ describe Hbc::CLI, :cask do
it "shows a user-friendly error message" do it "shows a user-friendly error message" do
expect { expect {
Hbc::CLI.process_options %w[install -f] Hbc::CLI.process_options %w[install -f]
}.to raise_error(Hbc::CaskError) }.to raise_error(ArgumentError)
end end
end end
@ -116,7 +116,7 @@ describe Hbc::CLI, :cask do
it "shows a user-friendly error message" do it "shows a user-friendly error message" do
expect { expect {
Hbc::CLI.process_options %w[edit -c] Hbc::CLI.process_options %w[edit -c]
}.to raise_error(Hbc::CaskError) }.to raise_error(ArgumentError)
end end
end end